add insert_or_update/2 and insert_or_update!/2 #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution @cschmatzler ! I'll review this PR within this 7 days. |
izelnakri
reviewed
May 28, 2021
| when model: struct | ||
| def insert_or_update( | ||
| changeset, | ||
| options \\ [origin: nil, meta: nil, originator: nil, prefix: nil] |
There was a problem hiding this comment.
Could you also add the following to the default options list:
model_key: :model,
version_key: :version,
ecto_options: [],
initial_version_key: :initial_version,
izelnakri
approved these changes
May 28, 2021
|
Nice job, thank you for this feature! I'll pull and test it locally this week, meanwhile would appreciate if you apply my suggested default options to the methods. Talk to you soon :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finally fixes #23 after years